Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling
From: Oliver Neukum
Date: Tue Jul 19 2016 - 02:24:38 EST
On Mon, 2016-07-18 at 17:04 +0200, Kristian Evensen wrote:
> On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum <oneukum@xxxxxxxx> wrote:
> >> Ok, sounds good. So far, I have only seen the random MAC issue with
> >> the three previously mentioned devices, but who knows how many else is
> >> out there with the same error ... I don't think it should be in the
> >> core ethernet code, at least not yet, but I agree it would make sense
> >> to move it to for example usbnet_core(). If you agree, I can prepare a
> >> patch for it.
> > I don't see how it would be specific for a subsystem. If the patch
> > is correct, it belongs into the networking core.
> I had a look at some other drivers, and I think we need to be very
> careful about making setting a random MAC too generic. For example, we
> might be unlucky and break the possibly_iphdr()-code/assumption in
> qmi_wwan.c. And there is probably more code/assumptions like that in
> the network stack.
In this case please use special cases for usbnet, too.
We need a quirk.