Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver
From: Guenter Roeck
Date: Thu Jul 21 2016 - 18:09:47 EST
On Thu, Jul 21, 2016 at 01:55:56PM -0700, Hoan Tran wrote:
> This patch adds hardware temperature and power reading support for
> APM X-Gene SoC using the mailbox communication interface.
> Signed-off-by: Hoan Tran <hotran@xxxxxxx>
[ ... ]
> + dev_info(&pdev->dev, "APM X-Gene SoC HW monitor driver registered\n");
> + return rc;
Nitpick: rc == 0 here, so return 0; is a better choice.
Otherwise looks good.
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Note that I can not apply the patch at this time due to its dependency.