Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver
From: Hoan Tran
Date: Thu Jul 21 2016 - 18:21:17 EST
On Thu, Jul 21, 2016 at 3:09 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On Thu, Jul 21, 2016 at 01:55:56PM -0700, Hoan Tran wrote:
>> This patch adds hardware temperature and power reading support for
>> APM X-Gene SoC using the mailbox communication interface.
>> Signed-off-by: Hoan Tran <hotran@xxxxxxx>
> [ ... ]
>> + dev_info(&pdev->dev, "APM X-Gene SoC HW monitor driver registered\n");
>> + return rc;
> Nitpick: rc == 0 here, so return 0; is a better choice.
> Otherwise looks good.
Yes, I'll fix it then send v4 shortly.
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Note that I can not apply the patch at this time due to its dependency.
Thanks ! I'll let you know when Rafael applies that dependent patch