Re: [GIT PULL] trivial for 4.9
From: Linus Torvalds
Date: Fri Oct 07 2016 - 17:37:27 EST
On Fri, Oct 7, 2016 at 2:06 PM, Linus Torvalds
> And btw, even without an explicit KERN_<level>, you should still not
> get any interleaving. Only an _explicit_ KERN_CONT should cause
Btw, note the "should" there. Because we do seem to have broken that
_again_. It worked fine at some point, but lookie here:
Author: Joe Perches <joe@xxxxxxxxxxx>
Date: Mon Jul 30 14:40:21 2012 -0700
printk: remove the now unnecessary "C" annotation for KERN_CONT
Now that all KERN_<LEVEL> uses are prefixed with ASCII SOH, there is no
need for a KERN_CONT. Keep it backward compatible by adding #define
Joe, you *are* the problem here.
So you are literally the person who broke this.
Goddammit, I don't want to hear another peep from you. You broke this
because you wanted to save a few bytes in those strings, and then
*because* you broke it, you then argue for putting those bytes back in
the form of "\n" characters.
Fuck me sideways. You make this big deal about how this interleaving
is a big problem, and at no point did you actually point to the real
issue, which was your very own breakage where you made it all fragile.