Re: [PATCH 24/54] md/raid1: Improve another size determination in setup_conf()

From: BjÃrn Mork
Date: Mon Oct 10 2016 - 10:01:18 EST


Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:

> I am ignoring Markus patches and have told him that he should focus on
> bug fixes. These patches don't add any value and regularly introduce
> bugs.

I think there should be a big fat warning in CodingStyle:

THIS DOCUMENT DOES NOT APPLY TO ANY EXISTING KERNEL CODE.


Preserving existing style is more important than any minor style issue
anyway. Style changes for the only purpose of style change should be
considered harmful and destructive behaviour. You'd think that is bloody
obvious, but evidently it isn't. Not only are the untested, buggy,
churning patches still being submitted - some of them are even applied!

Adding such a statement will not prevent style changes, even changes
to bring code more in line with CodingStyle, as long as the patches are
part of some work of substance. E.g. cleaning up before fixing bugs. If
you submit new code, then you can of course fix the style of any touched
context.

Oh well, I can dream..


BjÃrn