Re: linux.git: printk() problem

From: Michal Hocko
Date: Thu Oct 13 2016 - 02:26:13 EST


On Wed 12-10-16 09:08:58, Joe Perches wrote:
> On Wed, 2016-10-12 at 16:35 +0200, Michal Hocko wrote:
> > On Wed 12-10-16 22:30:03, Tetsuo Handa wrote:
> > > Hello.
> > >
> > > I noticed that current linux.git generates hardly readable console output
> > > due to KERN_CONT changes. Are you suggesting developers that output like
> > > this be fixed?
> >
> >
> > Joe has already posted a patch
> > http://lkml.kernel.org/r/c7df37c8665134654a17aaeb8b9f6ace1d6db58b.1476239034.git.joe@xxxxxxxxxxx
> >
> > And in general I think that adding those KERN_CONT is a good thing to
> > do.
>
> As do I, but there are about a quarter _million_ uses of
> printk/logging messages in the kernel tree with newlines.
>
> Maybe 100 or so of the existing messages lack terminating
> newlines.

I think they are not critical and can be fix once somebody notices.

--
Michal Hocko
SUSE Labs