Re: [GIT PULL] readlink cleanup

From: Al Viro
Date: Sat Dec 10 2016 - 21:36:48 EST

On Sat, Dec 10, 2016 at 09:41:45PM +0100, Miklos Szeredi wrote:
> Hi Al,
> Please pull from:
> git:// readlink
> This is a rework of the readlink cleanup patchset. Now readlink(2) does the
> following:
> - if i_op->readlink() is non-NULL (only proc and afs mountpoints for now) then
> it calls that;
> - otherwise call i_op->get_link();
> - signature of ->readlink() now matches that of ->get_link();
> This is against the #misc branch (the stats look better that way ;)

I'm still not sure what does "vfs: convert ->readlink to same signature as
->get_link" buy us. If anything, the result appears to be more complex -
you make freeing that buffer delayed (and introduce a dynamically allocated
buffer in one case that didn't use it)...