Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init()

From: Chunyan Zhang
Date: Tue Jan 10 2017 - 02:38:06 EST


On 10 January 2017 at 02:31, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Sun, Jan 8, 2017 at 10:42 PM, SF Markus Elfring
> <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> Date: Sun, 8 Jan 2017 18:44:26 +0100
>>
>> * A multiplication for the size determination of a memory allocation
>> indicated that an array data structure should be processed.
>> Thus use the corresponding function "kmalloc_array".
>>
>> This issue was detected by using the Coccinelle software.
>>
>> * Replace the specification of a data structure by a pointer dereference
>> to make the corresponding size determination a bit safer according to
>> the Linux coding style convention.
>>
>> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>
> Chunyan has been running this test code so she might have additional
> insights to provide. I am not aware about anyone else really running the
> tests, are there people who do it?

I talked about mmc_test on #armlinux channel with a person whose
nickname was s84 other day. It seemed that s84 was also trying to use
mmc_test module.

Regards,
Chunyan

>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Yours,
> Linus Walleij