Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64
From: Takashi Iwai
Date: Thu Feb 23 2017 - 09:24:26 EST
On Thu, 23 Feb 2017 15:11:46 +0100,
Andreas FÃrber wrote:
> Am 22.02.2017 um 19:47 schrieb Mark Brown:
> > On Wed, Feb 22, 2017 at 03:29:24AM +0100, Andreas FÃrber wrote:
> > This is patch 4 of 8, what's going on with dependencies here?
> No dependencies on previous patches. 5/8 adds ARCH_MMP to arm64.
> It compiled without this (just Kconfig warnings), so this could go
> through the appropriate sound tree as a cleanup.
> > Please use subject lines matching the style for the subsystem. This
> > makes it easier for people to identify relevant patches.
> Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM,
> which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC
> can be found in "ALSA for SoC audio support" section.', which confused
> me about whether or not this is an ASoC compliant driver if it selects a
> non-ASoC symbol.
It's a bug that selects SND_ARM there. I guess this was wrongly taken
from the old example of AC97 ARM SoC code, which was fixed later.
ASoC stuff is basically irrelevant from the legacy sound/arm/*.