Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64

From: Andreas FÃrber
Date: Thu Feb 23 2017 - 09:46:59 EST

Am 23.02.2017 um 15:24 schrieb Takashi Iwai:
> On Thu, 23 Feb 2017 15:11:46 +0100,
> Andreas FÃrber wrote:
>> Am 22.02.2017 um 19:47 schrieb Mark Brown:
>>> Please use subject lines matching the style for the subsystem. This
>>> makes it easier for people to identify relevant patches.
>> Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM,
>> which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC
>> can be found in "ALSA for SoC audio support" section.', which confused
>> me about whether or not this is an ASoC compliant driver if it selects a
>> non-ASoC symbol.
> It's a bug that selects SND_ARM there. I guess this was wrongly taken
> from the old example of AC97 ARM SoC code, which was fixed later.
> ASoC stuff is basically irrelevant from the legacy sound/arm/*.

Thanks, Takashi-san. I'll update as follows then.

diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index f8e1c06..aba7213 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -9,10 +9,9 @@ config SND_PXA2XX_SOC

config SND_MMP_SOC
bool "SoC Audio for Marvell MMP chips"
- depends on ARCH_MMP && ARM
- select MMP_SRAM
+ depends on ARCH_MMP || COMPILE_TEST
+ select MMP_SRAM if ARM
- select SND_ARM
Say Y if you want to add support for codecs attached to
the MMP SSPA interface.

Okay to do that in one patch or break up into three?


SUSE Linux GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)