Re: [alsa-devel] [PATCH] ASoC: cht_bsw_max98090_ti: Remove unused function cht_get_codec_dai()

From: Pierre-Louis Bossart
Date: Tue May 23 2017 - 15:49:21 EST

On 5/23/17 12:32 PM, Matthias Kaehlcke wrote:
Hi Pierre-Louis,

El Tue, May 23, 2017 at 12:25:17PM -0700 Pierre-Louis Bossart ha dit:

On 5/23/17 12:05 PM, Matthias Kaehlcke wrote:
Looks like the function has never been used since it was added by commit
17119a465706 ("ASoC: Intel: Add Cherrytrail & Braswell machine driver
cht_bsw_max98090_ti"). Removing it fixes the following warning when
building with clang:

sound/soc/intel/boards/cht_bsw_max98090_ti.c:42:35: error: unused
function 'cht_get_codec_dai' [-Werror,-Wunused-function]

Fine but it'll have to be re-added when I finally find the time to
support Baytrail with this driver.

If you have plans to add the code in a nearish future it is probably
not worth to do the removal, unless the maintainers think otherwise.

I have patches for this on github, but I've been unable to force the Rambi system I have into submission to boot my image from USB.

Like I said, it's fine if you want to get rid of the warning for now, I am not going to be able to work on this before August.

Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
sound/soc/intel/boards/cht_bsw_max98090_ti.c | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/sound/soc/intel/boards/cht_bsw_max98090_ti.c b/sound/soc/intel/boards/cht_bsw_max98090_ti.c
index 742bc0d4e681..20755ecc7f9e 100644
--- a/sound/soc/intel/boards/cht_bsw_max98090_ti.c
+++ b/sound/soc/intel/boards/cht_bsw_max98090_ti.c
@@ -39,18 +39,6 @@ struct cht_mc_private {
bool ts3a227e_present;

-static inline struct snd_soc_dai *cht_get_codec_dai(struct snd_soc_card *card)
- struct snd_soc_pcm_runtime *rtd;
- list_for_each_entry(rtd, &card->rtd_list, list) {
- if (!strncmp(rtd->codec_dai->name, CHT_CODEC_DAI,
- strlen(CHT_CODEC_DAI)))
- return rtd->codec_dai;
- }
- return NULL;
static const struct snd_soc_dapm_widget cht_dapm_widgets[] = {
SND_SOC_DAPM_HP("Headphone", NULL),
SND_SOC_DAPM_MIC("Headset Mic", NULL),