Re: [GIT PULL] NTB bug fixes for v4.12

From: Jon Mason
Date: Tue Jun 20 2017 - 10:59:55 EST


On Mon, Jun 19, 2017 at 11:06 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Jun 20, 2017 at 2:42 AM, Jon Mason <jdmason@xxxxxxxx> wrote:
>> Hello Linus,
>> Here are a few NTB bug fixes for 4.12.
>
> So I pulled this, mainly because it removed more lines than it added
> due to the revert.
>
> But generally I absolutely *hate* pulling stuff that I can see was
> committed just hours ago. Why was that branch so recent? It very
> obviously cannot have been in any linux-next or 0day or gotten any
> other exposure. Is there a reason for that behavior? And if there is,

This was in my ntb branch since June 9th. Previously, it was based on
v4.12-rc4. Immediately prior to doing the pull request, I did a
rebase to rc6 to avoid any potential issues you might have applying
them.

> just include it in the "please pull", because if it wasn't for the
> "removes more lines than adds" I probably would just have decided to
> ignore this.

In the future, I will endeavor to be more verbose. I will include the
previous version that it was based on and the testing done by the NTB
developer community. I apologize for not doing this in this pull
request, and I appreciate you asking me and not simply ignoring my
email.

Thanks,
Jon

>
> Linus