RE: [PATCH V2] tipc: Use bsearch library function

From: Jon Maloy
Date: Sun Sep 17 2017 - 12:28:24 EST

> -----Original Message-----
> From: Thomas Meyer [mailto:thomas@xxxxxxxx]
> Sent: Sunday, September 17, 2017 11:00
> To: Jon Maloy <jon.maloy@xxxxxxxxxxxx>
> Cc: Joe Perches <joe@xxxxxxxxxxx>; Ying Xue <ying.xue@xxxxxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; tipc-discussion@xxxxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx
> Subject: Re: [PATCH V2] tipc: Use bsearch library function
> > Am 16.09.2017 um 15:20 schrieb Jon Maloy <jon.maloy@xxxxxxxxxxxx>.
> >>
> >> What part of "very time critical" have you verified and benchmarked as
> >> inconsequential?
> >>
> >> Please post your results.
> >
> > I agree with Joe here. This change does not simplify anything, it does
> reduce the amount of code, plus that it introduce an unnecessary outline
> in a place where we have every reason to let the compiler do its
> job properly.
> Hi,
> Okay, should I prepare some performance numbers or do we NAK this
> change?
> What about the other binary search implementation in the same file? Should
> I try to convert it it will it get NAKed for performance reasons too?

The searches for inserting and removing publications is less time critical,
so that would be ok with me.
If you have any more general interest in improving the code in this file
(which is needed) it would also be appreciated.


> With kind regards
> Thomas

Attachment: smime.p7s
Description: S/MIME cryptographic signature