Re: [PATCH 4/9] posix-clocks: Enable compat syscalls always

From: Thomas Gleixner
Date: Mon Nov 13 2017 - 16:03:50 EST


On Fri, 10 Nov 2017, Deepa Dinamani wrote:
>
> -#ifdef CONFIG_COMPAT
> -
> COMPAT_SYSCALL_DEFINE2(nanosleep, struct compat_timespec __user *, rqtp,
> struct compat_timespec __user *, rmtp)
> {
> @@ -1574,7 +1572,6 @@ COMPAT_SYSCALL_DEFINE2(nanosleep, struct compat_timespec __user *, rqtp,
> current->restart_block.nanosleep.compat_rmtp = rmtp;
> return hrtimer_nanosleep(&tu, HRTIMER_MODE_REL, CLOCK_MONOTONIC);
> }
> -#endif

So if I'm not missing something important this will make the compat syscall
define available even for

CONFIG_X86_64=y
CONFIG_IA32_EMULATION=n
CONFIG_X86_X32=n

which is wrong because in that configuration we don't have any 32bit
executable support. So why would we need a compat syscall in that case?

Thanks,

tglx