Re: [PATCH 1/1] target:separate tx/rx cmd_puds
From: David Disseldorp
Date: Fri Apr 06 2018 - 08:09:44 EST
On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote:
> > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds);
> > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds);
> > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, rx_cmds);
> I don't think the in_cmds metric should be deleted here. It could be
> calculated on the fly via tx_cmds + rx_cmds + nodata_cmds.
@Zhang Zhuoyu: How about something like the following?
...this keeps the in_cmds metric, and renames tx/rx_cmds read/write_cmds
respectively. read/write_cmds is still a bit ambiguous, as it refers to
the command data direction rather than SCSI READ/WRITE CDBs, but IMO
it's clearer, and more consistent with the read/write_mbytes metrics.