Re: [PATCH 2/2] printk: wake up klogd in vprintk_emit

From: Sergey Senozhatsky
Date: Wed Apr 18 2018 - 21:17:37 EST


On (04/18/18 11:10), Steven Rostedt wrote:
>
> > > Calling wake_up_klogd() will grab the rq lock and give us a A-B<->B-A
> > > locking order.
> >
> > wake_up_klogd() uses the lockless irq_work_queue(). So it is actually
> > safe.
>
> I didn't look at the code. OK then we don't need to worry about that.

OK.

> >
> > But the name is confusing. We should rename it.
>
> Yes, I would because the old wake_up_klogd() did do a wakeup. Perhaps
> we should name it: kick_klogd().

Agreed.

-ss