Re: [PATCH 17/18] perf/x86/intel/rapl: Support multi-die/package

From: Len Brown
Date: Mon May 06 2019 - 13:29:28 EST


On Mon, May 6, 2019 at 7:48 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> > - unsigned int pkgid = topology_logical_package_id(cpu);
> > + unsigned int pkgid = topology_logical_die_id(cpu);

> There's many such instances left in this series, please review the whole
> patchset for such problems.

I agree, the legacy names make the code read as if it were a bug, even
when it is correct.
I'll refresh the series with some re-names to make the end result ready clearly.

thanks!
Len Brown, Intel Open Source Technology Center