Re: [PATCH 01/10] PCI/AER: Replace dev_printk(KERN_DEBUG) with dev_info()
From: Andy Shevchenko
Date: Thu May 09 2019 - 13:37:43 EST
On Thu, May 9, 2019 at 5:17 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> From: Frederick Lawler <fred@xxxxxxxxxxxx>
> Replace dev_printk(KERN_DEBUG) with dev_info() or dev_err() to be more
> consistent with other logging.
> These could be converted to dev_dbg(), but that depends on
> CONFIG_DYNAMIC_DEBUG and DEBUG, and we want most of these messages to
> *always* be in the dmesg log.
> Also remove a redundant kzalloc() failure message.
> + pci_info(parent, "can't find device of ID%04x\n",
> + e_info->id);
Would it be a chance to take them one line instead of two?
> + dev_err(device, "request AER IRQ %d failed\n",
> + dev->irq);
With Best Regards,