Re: [PATCH] kbuild: s390, do not remove autogenerated headers on clean

From: Masahiro Yamada
Date: Wed Jun 05 2019 - 07:33:51 EST

On Wed, Jun 5, 2019 at 8:14 PM Jiri Slaby <jslaby@xxxxxxx> wrote:
> 'make clean' does NOT remove autogenerated headers generated from
> arch/s390/kernel/syscalls/. For example:
> asm-offsets.h
> irq_regs.h
> irq_work.h
> unistd_nr.h
> But 'make clean' DOES currently remove dis-defs.h and facility-defs.h
> generated from arch/s390/tools/.
> The issue is that facility-defs.h is included from <asm/facility.h> and
> builds of external modules fail due to missing header. (When cleaned
> build directory is used.)
> Fix this by adding these targets to no-clean-files.
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Cc: Michal Marek <michal.lkml@xxxxxxxxxxx>
> Cc: linux-kbuild@xxxxxxxxxxxxxxx
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> Cc: linux-s390@xxxxxxxxxxxxxxx
> ---
> I would love to see comments from KBuild guys as I am not sure if this
> fix is correct at all.

This issue had already been fixed by the side-effect of
another patch, which is in linux-next.

See this:

commit 10077c9f2dae1afabab2808a0326ecf3e8e5a82c
Author: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Date: Fri May 17 16:54:27 2019 +0900

s390: drop meaningless 'targets' from tools Makefile

'targets' should be specified to include .*.cmd files to evaluate
if_changed or friends.

Here, facility-defs.h and dis-defs.h are generated by filechk.

Because filechk does not generate .*.cmd file, the 'targets' addition
is meaningless. The filechk correctly updates the target when its
content is changed.

Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>


Best Regards
Masahiro Yamada