Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code
From: Geert Uytterhoeven
Date: Thu Jul 04 2019 - 08:10:36 EST
On Thu, Jul 4, 2019 at 2:08 PM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote:
> > gcc-9 complains about a blatant uninitialized variable use that
> > all earlier compiler versions missed:
> > drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > Return -EINVAL instead here.
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> This is correct but missing that the above 'return ret' is broken, too.
> ret is initialized but 0 in that case.
Nice catch! Oh well, given enough eyeballs, ...
> And maybe we can use something else than -EINVAL for this case? I am on
> the go right now, I will look for a suggestion later.
-EINVAL is correct here (and in the above case, too), IMHO.
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds