Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

[Marek Vasut]

On 7/4/19 2:10 PM, Geert Uytterhoeven wrote:
> Hi Wolfram,
> 
> On Thu, Jul 4, 2019 at 2:08 PM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>> On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote:
>>> gcc-9 complains about a blatant uninitialized variable use that
>>> all earlier compiler versions missed:
>>>
>>> drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> Return -EINVAL instead here.
>>>
>>> Cc: stable@xxxxxxxxxxxxxxx
>>> Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> This is correct but missing that the above 'return ret' is broken, too.
>> ret is initialized but 0 in that case.
> 
> Nice catch! Oh well, given enough eyeballs, ...

I don't think ret is initialized, reg is, not ret .

>> And maybe we can use something else than -EINVAL for this case? I am on
>> the go right now, I will look for a suggestion later.
> 
> -EINVAL is correct here (and in the above case, too), IMHO.

Yep, -EINVAL is fine.

-- 
Best regards,
Marek Vasut