Re: [PATCH v2 2/3] fbdev: fbmem: allow overriding the number of bootup logos

From: Geert Uytterhoeven
Date: Tue Aug 27 2019 - 04:36:51 EST

Hi Peter,

On Mon, Aug 26, 2019 at 10:46 PM Peter Rosin <peda@xxxxxxxxxx> wrote:
> Probably most useful if you only want one logo regardless of how many
> CPU cores you have.
> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>

Thanks for your patch!

> --- a/Documentation/fb/fbcon.rst
> +++ b/Documentation/fb/fbcon.rst
> @@ -174,6 +174,11 @@ C. Boot options
> displayed due to multiple CPUs, the collected line of logos is moved
> as a whole.
> +9. fbcon=logo-count:<n>
> +
> + The value 'n' overrides the number of bootup logos. Zero gives the
> + default, which is the number of online cpus.

Isn't that a bit unexpected for the user?
What about making -1 the default (auto), and zero meaning no logos?



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds