RE: [PATCH v2 -next] crypto: inside-secure - Fix build error without CONFIG_PCI
From: Pascal Van Leeuwen
Date: Wed Sep 04 2019 - 08:45:05 EST
So, with that patch you ONLY get a warning on that unused int rc, right?
I do understand that one, that should have been inside an #ifdef as well.
Everybody happy if I just fix that and leave the rest as is?
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
> -----Original Message-----
> From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, September 4, 2019 2:32 PM
> To: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> Cc: Pascal Van Leeuwen <pvanleeuwen@xxxxxxxxxxxxxx>; YueHaibing <yuehaibing@xxxxxxxxxx>;
> antoine.tenart@xxxxxxxxxxx; davem@xxxxxxxxxxxxx; pvanleeuwen@xxxxxxxxxxxxxxxx; linux-
> crypto@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 -next] crypto: inside-secure - Fix build error without CONFIG_PCI
> On Wed, Sep 04, 2019 at 05:27:19AM -0700, Ard Biesheuvel wrote:
> > Did you try disabling CONFIG_PCI?
> Indeed. Even with my patch if you compile with CONFIG_PCI you still
> get a warning:
> CC [M] drivers/crypto/inside-secure/safexcel.o
> ../drivers/crypto/inside-secure/safexcel.c: In function \u2018safexcel_init\u2019:
> ../drivers/crypto/inside-secure/safexcel.c:1506:6: warning: unused variable \u2018rc\u2019
> int rc;
> We should fix that in inside-secure.
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt