Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn

From: Qian Cai
Date: Thu Nov 28 2019 - 12:23:03 EST




> On Nov 28, 2019, at 10:46 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote:
>
> I tend to push back on cleanups without a clear added value. In this
> particular case it is not about aesthetic or a personal feeling about
> the code though. Please read my comment with the ack.

I can only encourage you to push back more in general especially for those micro-size cleanups. On the other hand, it could be arbitrary because once you are gone for vacations or some other reasons, it will be inconsistent of reviewing. You are mostly of my first defense those days.