Re: [PATCH v3 02/22] compat: provide compat_ptr() on all architectures

From: Arnd Bergmann
Date: Tue Jan 07 2020 - 03:08:54 EST


On Tue, Jan 7, 2020 at 3:05 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> Arnd Bergmann <arnd@xxxxxxxx> writes:
> > +
> > +static inline compat_uptr_t ptr_to_compat(void __user *uptr)
> > +{
> > + return (u32)(unsigned long)uptr;
> > +}
>
> Is there a reason we cast to u32 directly instead of using compat_uptr_t?

Probably Al found this to be more explicit at the time when he introduced
it on all the architectures in 2005. I just moved it here and kept the
definition.

Arnd