Re: Input: ep93xx_keypad: Checking for a failed platform_get_irq() call in ep93xx_keypad_probe()

From: Markus Elfring
Date: Fri Apr 10 2020 - 01:46:21 EST


> Platform code historically allowed creating IRQ resources with IRQ
> number 0 to indicate "no interrupt assigned", so this driver tries to
> filter out such conditions. The negative IRQs (errors) will be rejected
> by request_irq() but I guess we can lose -EPROBE_DEFER.

Thanks for this explanation.

* Should such information be better represented in the description for
these programming interfaces?

* Can the software documentation become clearer anyhow?


> or, maybe we should take a look at platform_get_irq() and see if we can
> stop it returning 0 interrupt numbers and clean up the drivers.

Will further collateral evolution become interesting?

Regards,
Markus