Re: [PATCH] time/sched_clock: mark sched_clock_read_begin as notrace

From: Steven Rostedt
Date: Mon Sep 28 2020 - 17:33:36 EST


On Mon, 28 Sep 2020 12:58:59 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > -struct clock_read_data *sched_clock_read_begin(unsigned int *seq)
> > +notrace struct clock_read_data *sched_clock_read_begin(unsigned int *seq)
> > {
> > *seq = raw_read_seqcount_latch(&cd.seq);
> > return cd.read_data + (*seq & 1);
>
> At the very least sched_clock_read_retry() should also be marked such.
>
> But Steve, how come x86 works? Our sched_clock() doesn't have notrace on
> at all.

It's because of that magic in the Makefile that you love so much ;-)

CFLAGS_REMOVE_tsc.o = -pg

-- Steve