Re: [PATCH] time/sched_clock: mark sched_clock_read_begin as notrace

[Peter Zijlstra]

On Mon, Sep 28, 2020 at 05:33:31PM -0400, Steven Rostedt wrote:
> On Mon, 28 Sep 2020 12:58:59 +0200
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> 
> > > -struct clock_read_data *sched_clock_read_begin(unsigned int *seq)
> > > +notrace struct clock_read_data *sched_clock_read_begin(unsigned int *seq)
> > >  {
> > >  	*seq = raw_read_seqcount_latch(&cd.seq);
> > >  	return cd.read_data + (*seq & 1);  
> > 
> > At the very least sched_clock_read_retry() should also be marked such.
> > 
> > But Steve, how come x86 works? Our sched_clock() doesn't have notrace on
> > at all.
> 
> It's because of that magic in the Makefile that you love so much ;-)
> 
> CFLAGS_REMOVE_tsc.o = -pg

ARGH!!, I really should write a script to fix up that mess :/