Re: [PATCH 2/2] staging: r8188eu: Make some clean-ups in usbctrl_vendorreq()

From: Pavel Skripkin
Date: Tue Aug 24 2021 - 11:43:37 EST

On 8/24/21 6:39 PM, Fabio M. De Francesco wrote:
On Tuesday, August 24, 2021 5:26:23 PM CEST Pavel Skripkin wrote:
I found the problem:

> mutex_lock(&dvobjpriv->usb_vendor_req_mutex);
> > /* Acquire IO memory for vendorreq */
> - pIo_buf = dvobjpriv->usb_vendor_req_buf;
> + io_buf = dvobjpriv->usb_vendor_req_buf;

I don't know from where mutex_lock() comes from. In staging-next I have

_enter_critical_mutex(&dvobjpriv->usb_vendor_req_mutex, NULL);

instead of


Oh, I know where it comes from... :)

It's a patch of mine that is in the queue, waiting to be reviewed and applied.
Please see:

oh.... there are _a lot_ of pending changes :)

I guess, we need smth like public-mirror with already reviewed and working changes

With regards,
Pavel Skripkin