Re: [PATCH] iwlwifi: pnvm: Fix a memory leak in 'iwl_pnvm_get_from_fs()'
From: Coelho, Luciano
Date: Fri Sep 03 2021 - 04:55:38 EST
On Fri, 2021-09-03 at 11:19 +0300, Dan Carpenter wrote:
> On Thu, Sep 02, 2021 at 10:38:11PM +0200, Christophe JAILLET wrote:
> > A firmware is requested but never released in this function. This leads to
> > a memory leak in the normal execution path.
> > Add the missing 'release_firmware()' call.
> > Also introduce a temp variable (new_len) in order to keep the value of
> > 'pnvm->size' after the firmware has been released.
> > Fixes: cdda18fbbefa ("iwlwifi: pnvm: move file loading code to a separate function")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Luca Coelho <luca@xxxxxxxxx>
Kalle, can you please queue this for v5.15? I'll assign it to you.