Re: [PATCH 1/3] ASoc: amd: create platform device for VG machine driver

[Mark Brown]

On Tue, Oct 12, 2021 at 12:17:01AM +0530, Vijendar Mukunda wrote:

>  		pdevinfo[2].res = &adata->res[2];
>  
> +		pdevinfo[3].name = "acp5x_nu8821_cs35l41_mach";
> +		pdevinfo[3].id = 0;
> +		pdevinfo[3].parent = &pci->dev;

This appears to unconditionally assume that any machine with this
hardware is going to have exactly the same CODEC/amp combination - that
seems like it's going to go badly at some point.  Shouldn't there be
some other check that we're instantiating the right machine driver?

BTW your clock appears to be set quite a way into the future (possibly
about 24 hours?) which is confusing things.

Attachment: signature.asc
Description: PGP signature