Re: [PATCH v10 04/11] x86/tdx: Add TDX support to intel_cc_platform_has()

[Borislav Petkov]

On Fri, Oct 08, 2021 at 10:37:40PM -0700, Kuppuswamy Sathyanarayanan wrote:
> diff --git a/include/linux/cc_platform.h b/include/linux/cc_platform.h
> index a075b70b9a70..6124527a0423 100644
> --- a/include/linux/cc_platform.h
> +++ b/include/linux/cc_platform.h
> @@ -61,6 +61,15 @@ enum cc_attr {
>  	 * Examples include SEV-ES.
>  	 */
>  	CC_ATTR_GUEST_STATE_ENCRYPT,
> +
> +	/**
> +	 * @CC_ATTR_GUEST_TDX: Trusted Domain Extension Support
> +	 *
> +	 * The platform/OS is running as a TDX guest/virtual machine.
> +	 *
> +	 * Examples include Intel TDX.

It already has "TDX" in the name - no need for "Examples ..."

> +	 */
> +	CC_ATTR_GUEST_TDX,

Yeah, we talked about putting those vendor-specific enums in a block so
that they're all consecutive, so please do

	CC_ATTR_GUEST_TDX	= 0x200

Brijesh already took the 0x100 range for SNP.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette