Re: [PATCH] usbip: tools: usbipd: fix duplicate option definition

[Shuah Khan]

On 10/13/21 8:57 AM, Alyssa Ross wrote:
> This seems to have been introduced by mistake in
> f49ad35cd124 ("staging: usbip: Fix IPv6 support in usbipd").

Thanks for the patch.

Add a sentence or two to say what is being fixed and use Fixes tag
for the commit.

> Signed-off-by: Alyssa Ross <hi@xxxxxxxxx>
> ---
>   tools/usb/usbip/src/usbipd.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/tools/usb/usbip/src/usbipd.c b/tools/usb/usbip/src/usbipd.c
> index 48398a78e88a..33e8512de7c4 100644
> --- a/tools/usb/usbip/src/usbipd.c
> +++ b/tools/usb/usbip/src/usbipd.c
> @@ -589,7 +589,6 @@ int main(int argc, char *argv[])
>   		{ "ipv4",     no_argument,       NULL, '4' },
>   		{ "ipv6",     no_argument,       NULL, '6' },
>   		{ "daemon",   no_argument,       NULL, 'D' },
> -		{ "daemon",   no_argument,       NULL, 'D' },
>   		{ "debug",    no_argument,       NULL, 'd' },
>   		{ "device",   no_argument,       NULL, 'e' },
>   		{ "pid",      optional_argument, NULL, 'P' },

thanks,
-- Shuah