Re: [PATCH v1 2/3] thermal/debugfs: Pass cooling device state to thermal_debug_cdev_add()

[Lukasz Luba]

On 4/25/24 19:53, Rafael J. Wysocki wrote:
> On Thu, Apr 25, 2024 at 8:42 PM Lukasz Luba <lukasz.luba@xxxxxxx> wrote:
> > On 4/25/24 14:00, Rafael J. Wysocki wrote:
> > > On Thu, Apr 25, 2024 at 2:36 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> > > > Hi Lukasz,
> > > >
> > > > On Thu, Apr 25, 2024 at 12:02 PM Lukasz Luba <lukasz.luba@xxxxxxx> wrote:
> > > > > Hi Rafael,
> > > > >
> > > > > On 4/23/24 19:00, Rafael J. Wysocki wrote:
> > > > > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > > > > >
> > > > > > If cdev_dt_seq_show() runs before the first state transition of a cooling
> > > > > > device, it will not print any state residency information for it, even
> > > > > > though it might be reasonably expected to print residency information for
> > > > > > the initial state of the cooling device.
> > > > > >
> > > > > > For this reason, rearrange the code to get the initial state of a cooling
> > > > > > device at the registration time and pass it to thermal_debug_cdev_add(),
> > > > > > so that the latter can create a duration record for that state which will
> > > > > > allow cdev_dt_seq_show() to print its residency information.
> > > > > >
> > > > > > Fixes: 755113d76786 ("thermal/debugfs: Add thermal cooling device debugfs information")
> > > > > > Reported-by: Lukasz Luba <lukasz.luba@xxxxxxx>
> > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > > > > > ---
> > > > > >     drivers/thermal/thermal_core.c    |    9 +++++++--
> > > > > >     drivers/thermal/thermal_debugfs.c |   12 ++++++++++--
> > > > > >     drivers/thermal/thermal_debugfs.h |    4 ++--
> > > > > >     3 files changed, 19 insertions(+), 6 deletions(-)
> > > > >
> > > > > I'm trying to test it on my board and do the review, but faced issue.
> > > > > For some reason I couldn't apply that patch on the latest bleeding-edge
> > > > > branch.
> > > > > Could you help me in this please? Is there something missing in the
> > > > > patch set (like one more fist patch)?
> > > >
> > > > I messed up the ordering of patches (patch [2/3] should be the last
> > > > one in the series) and on top of that, you'll need a small rebase on
> > > > that patch.
> > > >
> > > > Sorry about this, I'll send a v2.
> > >
> > > Actually, the ordering was OK, but the rebase of the second patch is
> > > still needed.  I'll send a v2.
> >
> > Thanks, I've seen it. That v2 applies smoothly and runs on the board.
> > I'll test it and review.
>
> Thank you!
>
> Please also see
>
> https://lore.kernel.org/linux-pm/12427744.O9o76ZdvQC@kreacher/
>
> which is actually more urgent because the fixes there address more
> serious issues (I would even consider them as 6.9-rc material).

Yes, I've read that patches' headers and glanced through the code.
I'll do the review & testing on them as well today.