Re: [PATCH net 1/4] net: qede: sanitize 'rc' in qede_add_tc_flower_fltr()

From: Simon Horman
Date: Sat Apr 27 2024 - 13:37:24 EST


On Fri, Apr 26, 2024 at 09:12:23AM +0000, Asbjørn Sloth Tønnesen wrote:
> Explicitly set 'rc' (return code), before jumping to the
> unlock and return path.
>
> By not having any code depend on that 'rc' remains at
> it's initial value of -EINVAL, then we can re-use 'rc' for
> the return code of function calls in subsequent patches.
>
> Only compile tested.
>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>
> ---
> drivers/net/ethernet/qlogic/qede/qede_filter.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>