Re: [PATCH net 2/4] net: qede: use return from qede_parse_flow_attr() for flower

From: Simon Horman
Date: Sat Apr 27 2024 - 13:37:40 EST


On Fri, Apr 26, 2024 at 09:12:24AM +0000, Asbjørn Sloth Tønnesen wrote:
> In qede_add_tc_flower_fltr(), when calling
> qede_parse_flow_attr() then the return code
> was only used for a non-zero check, and then
> -EINVAL was returned.
>
> qede_parse_flow_attr() can currently fail with:
> * -EINVAL
> * -EOPNOTSUPP
> * -EPROTONOSUPPORT
>
> This patch changes the code to use the actual
> return code, not just return -EINVAL.
>
> The blaimed commit introduced these functions.
>
> Only compile tested.
>
> Fixes: 2ce9c93eaca6 ("qede: Ingress tc flower offload (drop action) support.")
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>