Re: Tulip driver in 2.0.24

Brian Topping (topping@mauswerks.com)
Sun, 03 Nov 1996 13:39:01 -0800


Folks,

This was my bad. I don't know how the error was introduced, but as it
is plain to see there are a few digits missing. The correct value is a
singe bit difference between the two values. It was probably a bad copy
and paste, since my original source had the problem too. Unfortuantely
it didn't show up in testing here on a 21040.

Sorry about the problems. At least multicast finally works again...

-B

Ion Badulescu wrote:
>
> Hi,
>
> On Sun, 3 Nov 1996, Linux support wrote:
>
> > I was not able to get my smc8432 (DEC 21041 Tulip) card working with
> > 2.0.24.
> >
> > After restoring tulip.c to the 2.0.23 version, it works fine again.
> >
> > I got the message "eth0: enabling BNC port" repeating after some seconds,
> > but the interface does never come up.
>
> I've got the same problem with a 21041-based card: stock 2.0.24 does not
> work at all and instead cycles the port type; 2.0.23 works just fine as
> does 2.0.24 with tulip.c from 2.0.23; finally, 2.1.7 (which includes
> _almost_ the same changes to tulip.c as 2.0.24) again works fine.
>
> Now, there is a catch here: the difference between tulip.c in 2.1.7 and
> 2.0.24 is a constant. 2.1.7 has the correct value (as Linus pointed out in
> a previous message). This is the patch for 2.0.24 (apply it with -p1):
>
> --- linux/drivers/net/tulip.c.orig Sun Nov 3 12:02:47 1996
> +++ linux/drivers/net/tulip.c Fri Nov 1 06:58:44 1996
> @@ -1145,7 +1145,7 @@
> tp->tx_skbuff[entry] = 0;
> /* Put the setup frame on the Tx list. */
> tp->tx_ring[entry].length = 192 |
> - (entry == TX_RING_SIZE-1 ? 0x0a000000 : 0x08000);
> + (entry == TX_RING_SIZE-1 ? 0x0a000000 : 0x08000000);
> tp->tx_ring[entry].buffer1 = virt_to_bus((char *)tp->setup_frame);
> tp->tx_ring[entry].buffer2 = 0;
> tp->tx_ring[entry].status = TRING_OWN;
>
> Ionut
>
> --
> Ionut Badulescu - Columbia College '98 E-mail:ib42@columbia.edu
> Phone: (212)853-7875 Snail mail: 4A4 Wallach Hall
> Fax: (212)695-5560 1116 Amsterdam Ave
> PGP key available on request New York, NY 10027
> It is better to keep your mouth shut and be thought a fool,
> than to open it and remove all doubt.