Re: SLIP / ARP oops in 2.1.79 SMP.

A.N.Kuznetsov (
Fri, 16 Jan 1998 23:10:05 +0300 (MSK)


> Alexey, I've also made a minor change to call __neigh_lookup instead of
> neigh_lookup, as it's already bh_atomic.


> + /* N.B. Do we need bh_atomic locking here? */
> if (neigh) {
> memcpy(r->arp_ha.sa_data, neigh->ha, dev->addr_len);

You are right. Otherwise, if address will change during memcpy
we could get half of address from old one address and half
from new one.