Re: enable_ioapic_irq broken in arch/i386/kernel/irq.c

Linus Torvalds (torvalds@transmeta.com)
Sat, 25 Apr 1998 22:50:48 -0700 (PDT)


On Sun, 26 Apr 1998, David Woodhouse wrote:
>
> torvalds@transmeta.com said:
> > Would some io-apic people try out this patch to irq.c (patch against
> > 2.1.98)? It simplifies the irq handling quite a bit, I'd like to hear
> > whether it is stable for you..
>
> It appears to be utterly buggered.

;)

Which just shows hor differently different machines can react. I have one
pretty positive report already, and now one which calls it "utterly
buggered".

Oh, well.

> Upon first attempt: it got about as far as starting syslogd, before printing
> "eth0: Re-entering the interrupt handler" seven times and locking hard.
> The offending device was a tulip card, so I updated to Donald Becker's latest
> (v0.89B) and recompiled.

I'm rather surprised. The code shouldn't have changed anything like that,
especially as the tulip driver doesn't even use disable/enable_irq() as
far as I know (and without disable_irq(), the code behaviour should not
have changed).

> Admittedly, this kernel's got the PC Speaker driver in it, and is compiled
> with egcs -mcpu=pentium -march=pentium, but that's no excuse.

Even so. Could you try with gcc-2.7.2.1 and no PC speaker driver (and no
modules) just to cut down on "noise" in the environment. I'd feel happier
not having to worry about compilers etc - maybe the changes triggered a
compiler problem..

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu