Re: [PATCH v2] can: m_can: use us_to_ktime() in m_can_set_coalesce()

From: Marc Kleine-Budde
Date: Wed Aug 27 2025 - 03:37:52 EST


On 26.08.2025 17:38:17, Vincent Mailhol wrote:
[...]
> TLDR; the v1 was better than the v2. Speaking of the format, the only nitpick I
> might have is that after your change, the code fits in one line without
> exceeding the 80th column:
>
> if (cdev->rx_coalesce_usecs_irq)
> cdev->irq_timer_wait = us_to_ktime(cdev->rx_coalesce_usecs_irq);
> else
> cdev->irq_timer_wait = us_to_ktime(cdev->tx_coalesce_usecs_irq);

Good idea! Fixed why applying v1.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature