Re: [PATCH v2 1/2] sunrpc: remove dfprintk_cont() and dfprintk_rcu_cont()

From: Simon Horman
Date: Wed Aug 27 2025 - 10:24:14 EST


On Fri, Aug 22, 2025 at 09:19:22AM -0400, Jeff Layton wrote:
> KERN_CONT hails from a simpler time, when SMP wasn't the norm. These
> days, it doesn't quite work right since another printk() can always race
> in between the first one and the one being "continued".
>
> Nothing calls dprintk_rcu_cont(), so just remove it. The only caller of
> dprintk_cont() is in nfs_commit_release_pages(). Just use a normal
> dprintk() there instead, since this is not SMP-safe anyway.
>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>