Re: [PATCH v11 1/3] dt-bindings: iio: adc: add max14001
From: Marilene Andrade Garcia
Date: Sun Sep 21 2025 - 17:49:56 EST
On 21/09/2025 18:22, Conor Dooley wrote:
On Sat, Sep 20, 2025 at 06:44:52PM -0300, Marcelo Schmitt wrote:Ok, I will change that for v12. Thanks.
...
+ interrupts:
+ minItems: 1
+ items:
+ - description: |
+ Asserts high when ADC readings exceed the upper threshold and low
+ when below the lower threshold. Must be connected to the COUT pin.
+ - description: |
+ Alert output that asserts low during a number of different error
+ conditions. The interrupt source must be attached to FAULT pin.
These descriptions read wrong to me. They __are__ the COUT and FAULT
pins, given what David responded to above, not something that can be
connected to these pins (if they were, they would be represented as
-gpios rather than interrupts most likely). Unless you mean that these
pins can have some other use and are only available on the COUT/FAULT
pins when some register value is set - but even in that case saying
"must be" doesn't fit since the interrupt property could be used to
configure the device accordingly.
COUT and FAULT are just two pins on the ADC chip that can be used to generate
interrupts. Would a description like the one below sound better?
interrupts:
minItems: 1
items:
- description: |
cout: Comparator output signal that asserts high when ADC readings
exceed the upper threshold and low when readings fall below the lower
threshold.
I think you should mention the pin name here, like you did below.
"asserts high on the COUT pin" or w/e.
- description: |
fault: When fault reporting is enabled, the FAULT pin is asserted low
whenever one of the monitored fault conditions occurs.
Best regards,
Marcelo
Best Regards,
Marilene