Re: [PATCH v7 04/12] i2c: rtl9300: use regmap fields and API for registers
From: Wolfram Sang
Date: Thu Sep 25 2025 - 17:31:18 EST
On Sun, Aug 31, 2025 at 10:04:49AM +0000, Jonas Jelonek wrote:
> Adapt the RTL9300 I2C controller driver to use more of the regmap
> API, especially make use of reg_field and regmap_field instead of macros
> to represent registers. Most register operations are performed through
> regmap_field_* API then.
>
> Handle SCL selection using separate chip-specific functions since this
> is already known to differ between the Realtek SoC families in such a
> way that this cannot be properly handled using just a different
> reg_field.
>
> This makes it easier to add support for newer generations or to handle
> differences between specific revisions within a series. Just by
> defining a separate driver data structure with the corresponding
> register field definitions and linking it to a new compatible.
>
> Signed-off-by: Jonas Jelonek <jelonek.jonas@xxxxxxxxx>
> Tested-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>
> Reviewed-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> Tested-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> # On RTL9302C based board
> Tested-by: Markus Stockhausen <markus.stockhausen@xxxxxx>
I wanted to apply the rest of this series but applying fails. Can you
kindly rebase it to 6.17-rc5 or later?
Attachment:
signature.asc
Description: PGP signature