Re: [PATCH v7 04/12] i2c: rtl9300: use regmap fields and API for registers
From: Jonas Jelonek
Date: Thu Sep 25 2025 - 17:47:11 EST
On 25.09.25 23:30, Wolfram Sang wrote:
> On Sun, Aug 31, 2025 at 10:04:49AM +0000, Jonas Jelonek wrote:
>> Adapt the RTL9300 I2C controller driver to use more of the regmap
>> API, especially make use of reg_field and regmap_field instead of macros
>> to represent registers. Most register operations are performed through
>> regmap_field_* API then.
>>
>> Handle SCL selection using separate chip-specific functions since this
>> is already known to differ between the Realtek SoC families in such a
>> way that this cannot be properly handled using just a different
>> reg_field.
>>
>> This makes it easier to add support for newer generations or to handle
>> differences between specific revisions within a series. Just by
>> defining a separate driver data structure with the corresponding
>> register field definitions and linking it to a new compatible.
>>
>> Signed-off-by: Jonas Jelonek <jelonek.jonas@xxxxxxxxx>
>> Tested-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>
>> Reviewed-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
>> Tested-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> # On RTL9302C based board
>> Tested-by: Markus Stockhausen <markus.stockhausen@xxxxxx>
> I wanted to apply the rest of this series but applying fails. Can you
> kindly rebase it to 6.17-rc5 or later?
>
I just noticed that it seems like an already applied patch got lost [1].
This was supposed to be merged to Andi's i2c/i2c-host [2] and actually was
there until the first three patches of this series got merged.
Since I had already issue a few days ago trying to rebase the remaining
patches, this might be the cause it also fails for you?
Best,
Jonas Jelonek
[1] https://lore.kernel.org/linux-i2c/20250810-i2c-rtl9300-multi-byte-v5-5-cd9dca0db722@xxxxxxxxxxxxx/
[2] https://lore.kernel.org/linux-i2c/a422shurtl3xrvnh2ieynqq2kw5awqnmall2wjdpozx336m26i@54ekftmkwvrv/