Re: [PATCH 3/4] arm64: dts: qcom: x1-vivobook-s15: create a common dtsi for Hamoa and Purwa variants

[Maud Spierings]

On 2/9/26 09:57, Konrad Dybcio wrote:
> On 2/8/26 10:25 PM, Jens Glathe via B4 Relay wrote:
> > From: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
> >
> > The Asus VivoBook S15 S5507QA is sold with x1e-78-100 and x1p-42-100 SKUs.
> > Put the common part into one dtsi file to be included for model-specific dts.
> >
> > Signed-off-by: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
> > ---
> >   ...-vivobook-s15.dts => x1-asus-vivobook-s15.dtsi} | 28 ----------------------
> >   1 file changed, 28 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1-asus-vivobook-s15.dtsi
> > similarity index 97%
> > copy from arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> > copy to arch/arm64/boot/dts/qcom/x1-asus-vivobook-s15.dtsi
>
> I'd expect the part of the next patch that includes this new DTSI in
> the hamoa-based DTS to be present in this one

I thought so too at first but I think this works pretty well, make a 
copy that is changed but leave the original, then edit the original to 
use the editted copy.

Though I would argue patch 4/4 may want to be split between making the 
x1e version work with the new dtsi and another one to actually add the 
x1p version.

Personally I like this approach, but then I am not the maintainer.

Kind regards,
Maud