Re: [PATCH v4 3/3] arm64: dts: cix: add src syscon nodes for sky1 resets

[Krzysztof Kozlowski]

On Sun, Mar 01, 2026 at 03:09:10PM +0800, Xueyuan Chen wrote:
> Add the SRC blocks for the CIX Sky1 SoC. These blocks
> provide reset capabilities to various peripherals across
> the S0 and S5 domain.
> 
> Signed-off-by: Gary Yang <gary.yang@xxxxxxxxxxx>
> [Xueyuan Chen: Refactored to pure syscon nodes to fix v3 review issues]

v3? We are at v9!

> Signed-off-by: Xueyuan Chen <xueyuan.chen21@xxxxxxxxx>
> ---
>  arch/arm64/boot/dts/cix/sky1.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi
> index fb8c826bbc97..6ad5dc368a66 100644
> --- a/arch/arm64/boot/dts/cix/sky1.dtsi
> +++ b/arch/arm64/boot/dts/cix/sky1.dtsi
> @@ -348,6 +348,12 @@ i3c1: i3c@4100000 {
>  			status = "disabled";
>  		};
>  
> +		src_fch: reset-controller@4160000 {

Random set of changes without any explanation.

> +			compatible = "cix,sky1-src-fch", "syscon";
> +			reg = <0x0 0x04160000 0x0 0x90>;

And here...

Best regards,
Krzysztof