Re: [PATCH v2 1/6] dt-bindings: clock: qcom,sm6115-dispcc: Define MDSS resets

From: Dmitry Baryshkov

Date: Sun Mar 01 2026 - 08:15:20 EST


On Sun, Mar 01, 2026 at 12:52:57PM +0100, Krzysztof Kozlowski wrote:
> On Sat, Feb 28, 2026 at 05:41:27PM -0300, Val Packett wrote:
> > Add the missing defines for MDSS resets, which are necessary to reset
> > the display subsystem in order to avoid issues caused by state left over
> > from the bootloader.
> >
> > While here, align comment style with other SoCs.
> >
> > Fixes: 38557c6fc077 ("dt-bindings: clock: add QCOM SM6115 display clock bindings")
>
> IMO this is still not fix. Missing feature in original posting is not a
> bug, it's just incomplete posting which is in general accepted.
>
> Your commit msg tries to explain the bug and I see nothing relevant to
> this binding. From that explanation I see nothing wrong in mentioned
> fixed commit.
>
> Please drop fixes.

Here we have an interesting situation. Patches for the bindings and for
the clock driver are not fixes. The DT patch is a fix, because MDSS /
DPU can misbehave when switching from the bootloader configuration to
the running system.

>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> Best regards,
> Krzysztof
>

--
With best wishes
Dmitry