Re: [PATCH net-next v4] net: pppoe: implement GRO/GSO support

From: Qingfang Deng

Date: Mon Mar 02 2026 - 02:37:46 EST


On Sat, Feb 28, 2026 at 11:23 AM Qingfang Deng <dqfext@xxxxxxxxx> wrote:
> + /* ignore packets with padding or invalid length */
> + if (skb_gro_len(skb) != be16_to_cpu(phdr->length) + hlen)

Both Claude (Netdev AI Review) and Gemini said `hlen` should be
replaced with `sizeof(*phdr)`. Is that correct?