Re: [PATCH net-next v4] net: pppoe: implement GRO/GSO support

[Paolo Abeni]

On 3/2/26 8:34 AM, Qingfang Deng wrote:
> On Sat, Feb 28, 2026 at 11:23 AM Qingfang Deng <dqfext@xxxxxxxxx> wrote:
>> +       /* ignore packets with padding or invalid length */
>> +       if (skb_gro_len(skb) != be16_to_cpu(phdr->length) + hlen)
> 
> Both Claude (Netdev AI Review) and Gemini said `hlen` should be
> replaced with `sizeof(*phdr)`. Is that correct?

AFAICS, yes.

Side note: I think vlan encap it's not needed to observed the issue. You
should notice it even with plain PPPoE, if the ethernet NIC driver uses
napi_frags.

/P