Re: [PATCH net-next v4] NFC: pn544: i2c: Replace strcpy() with strscpy()

[Simon Horman]

On Sun, Mar 01, 2026 at 01:12:54PM +0100, tomasz.unger@xxxxxxxx wrote:
> From: Tomasz Unger <tomasz.unger@xxxxxxxx>
> 
> Replace strcpy() with strscpy() which limits the copy to the size of
> the destination buffer. Since phy->firmware_name is an array, the
> two-argument variant of strscpy() is used - the compiler deduces
> the buffer size automatically.
> 
> This is a defensive cleanup. As pointed out by Jakub Kicinski
> <kuba@xxxxxxxxxx>, firmware_name is already bounded to
> NFC_FIRMWARE_NAME_MAXSIZE via nla_strscpy() in net/nfc/netlink.c
> before reaching this driver, so no actual buffer overflow is possible.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@xxxxxxxx>
> ---
> Changes since v3:
> - Reworded commit message: removed "bug fix" and "buffer overflow"
>   language as pointed out by Jakub Kicinski <kuba@xxxxxxxxxx>;
>   firmware_name is already bounded via nla_strscpy() in netlink.c
> - Changed submission target from net to net-next (cleanup, not a fix)
> 
> Testing:
> - checkpatch.pl: 0 errors, 0 warnings
> - make M=drivers/nfc/pn544/: compiled successfully, 0 errors, 0 warnings

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>